Add SSL Support for Redis in Celery #2382 #2383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThomaciousD is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
8 tasks
|
Hi Thomas, thanks so much for this PR! This touches a file we just changed, so I've adapted your PR into a new one at #2389. Going to close this PR out but the new one should cover it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for Redis connections over SSL in the Celery configuration. It introduces new environment variables for SSL configuration, including
REDIS_SSL,REDIS_SSL_CERT_REQS, andREDIS_SSL_CA_CERTS.How Has This Been Tested?
Tested in live environment using a Redis instance with SSL server configured.
Accepted Risk
Misconfiguration of the SSL for Redis will lead to a fallback to the standard redis without SSL connexion, thus failing to process with a probable Connection Reset by Peer error.
Related Issue(s)
Checklist: